JVM build time improvements via tracking unused deps or classes [Kotlin part] #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviernotteghem
requested review from
cgruber,
timpeut and
restingbull
as code owners
Bencodes
reviewed
Oct 11, 2022
| @@ -25,6 +25,7 @@ kt_bootstrap_library( | |||
| "//src/main/kotlin/io/bazel/kotlin/builder/utils/jars", | |||
| "//src/main/protobuf:deps_java_proto", | |||
| "@com_github_jetbrains_kotlin//:kotlin-compiler", | |||
| "@kotlin_rules_maven//:com_google_guava_guava", | |||
There was a problem hiding this comment.
How much does this increase the release binary size of rules_kotlin?
There was a problem hiding this comment.
Final rules_kotlin_release.tgz went 19Mb->21.8Mb
nkoroste
reviewed
Nov 30, 2022
| "experimental_track_class_usage": attr.string( | ||
| doc = "Whether to track used classes", | ||
| default = "off", | ||
| values = [ |
There was a problem hiding this comment.
why not use booleans here?
There was a problem hiding this comment.
yeah.. I should change that. a boolean should be fine, not planning to use a third value here anymore..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Kotlin part of deps/classes tracking to achieve compilation avoidance.
Refer to Java part (TODO) for more info.