feat: add esbuild package #2252
Conversation
mattem
force-pushed
the
feat/package_esbuild
branch
2 times, most recently
from
621639c
to
1fff5c6
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
Seems there is a difference in path resolution behaviour between MacOS and Ubuntu in esbuild perhaps, will need to dig more into that. It passes on BuildKite though |
mattem
force-pushed
the
feat/package_esbuild
branch
2 times, most recently
from
20e64e3
to
5664099
Compare
|
@lukasholzer I'm stuck here on the Windows build. Do you have access to a Windows machine to debug? If not I'll try and source something this week. |
|
@mattem yea have a windows server via remote desktop :D – will give it a try the next days and try to fix it :) |
mattem
force-pushed
the
feat/package_esbuild
branch
5 times, most recently
from
a8138e8
to
db35bf6
Compare
|
Woo, windows is 🍏 Needs examples and docs 📖 |
mattem
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
mattem
force-pushed
the
feat/package_esbuild
branch
4 times, most recently
from
2448a6d
to
2b559d0
Compare
mattem
force-pushed
the
feat/package_esbuild
branch
2 times, most recently
from
9a85ee2
to
42955b1
Compare
mattem
force-pushed
the
feat/package_esbuild
branch
2 times, most recently
from
ebf1722
to
4d878bb
Compare
mattem
force-pushed
the
feat/package_esbuild
branch
from
4d878bb
to
da1f66e
Compare
|
rebased on stable |
mattem
force-pushed
the
feat/package_esbuild
branch
from
da1f66e
to
21166fd
Compare
mattem
force-pushed
the
feat/package_esbuild
branch
2 times, most recently
from
a69c04a
to
2e98c17
Compare
|
|
||
| _VERSION = "0.8.34" | ||
|
|
||
| def esbuild_dependencies(): |
There was a problem hiding this comment.
Could pass in the version & a dict of platform => SHA as a param (with default values for v0.8.34) so make it easier to use. Then docs could be updated to suggest using this helper.
There was a problem hiding this comment.
From your answer above, this would introduce eager loading for users which is not great
mattem
force-pushed
the
feat/package_esbuild
branch
from
2e98c17
to
c087357
Compare
|
🌮 very nice |
|
🚀 |
Adds the
@bazel/esbuildpackage, a thin, mildly opinionated wrapper around esbuild. The rule currently just calls the esbuild binary on the command line, further iterations of this could change to call the Go API, add workers and additional features.Example added to
examples/esbuild, along with unit tests under the package dir.In a previous iteration this PR included a repo rule to fetch the esbuild tool, however this has now been removed and user is expected to provide the binary to the rule via the
toolattribute. An example macro is included in the tests dir, and the examples show supporting multi-platforms.