fix(builtin): Update to latest ncc #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
approved these changes
Jul 2, 2019
|
Would this change possibly make vendoring the plugin @gregmagolan wanted here #761 a bit easier? |
This contains a fix for how browserify is built, so that builtin modules don't get arbitrary webpack-assigned module IDs Fixes bazelbuild#771
Definitely won't hurt. I'm hoping to look at that again this week @Toxicable. |
|
Tracked down what's broken here: browserify/browserify#1801 (comment) |
This is needed so that --preserve-symlinks browserify option also applies to the main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a fix for how browserify is built, so that builtin modules don't get arbitrary webpack-assigned module IDs
Fixes #771
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information