Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove bzlmod pip.parse() annotations attribute #1808

Merged
merged 4 commits into from May 19, 2024
Merged

fix: remove bzlmod pip.parse() annotations attribute #1808

merged 4 commits into from May 19, 2024
+5 −0

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Mar 15, 2024 •
edited by aignas

This change removes unused attributes from the bzlmod APIs cleaning up
the docs and src code.

@jbedard jbedard requested a review from rickeylev as a code owner March 15, 2024 21:48
@aignas
Copy link
Collaborator

aignas commented Mar 16, 2024

LGTM, could you add a changelog entry to the Changed section please?

@jbedard
Copy link
Contributor Author

jbedard commented Mar 16, 2024

@aignas updated, look ok?

aignas
aignas approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch and thanks for being patient. :)

@aignas aignas enabled auto-merge May 15, 2024 08:51
@aignas aignas added this pull request to the merge queue May 19, 2024
Merged via the queue into bazelbuild:main with commit 1036a4d May 19, 2024
4 checks passed
@jbedard jbedard deleted the bzlmod-attrs branch May 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbedard @aignas