fix(whl_library): fix the dependency generation for multi-python depenency closures #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We start using the recently introduced `is_python_config_setting` to make it possible to have a working select statement when multiple python version selection needs to happen in a `whl_library`. This adds further fixes so that the correct dependencies are pulled in when the `python_version` string flag is unset thus making this implementation suitable for `bzlmod` use case where we would use a single `whl_library` instance for multiple python versions within the hub. Work towards bazelbuild#735.
aignas
force-pushed
the
fix/whl-library-version-specifics
branch
from
151d40f
to
4f238a5
Compare
rickeylev
approved these changes
May 18, 2024
examples/bzlmod/MODULE.bazel
Outdated
| ], | ||
| hub_name = "pip", | ||
| python_version = "3.9", | ||
| quiet = False, |
There was a problem hiding this comment.
Just checking: debug code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start using the recently introduced
is_python_config_settingto makeit possible to have a working select statement when multiple python
version selection needs to happen in a
whl_library.This adds further fixes so that the correct dependencies are pulled in when the
python_versionstring flag is unset thus making this implementation suitablefor
bzlmoduse case where we would use a singlewhl_libraryinstance formultiple python versions within the hub.
Work towards #735.