Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Mark internal and python extension as reproducible #1892

Merged
merged 5 commits into from May 18, 2024
Merged

refactor: Mark internal and python extension as reproducible #1892

merged 5 commits into from May 18, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented May 12, 2024 •
edited

This avoids unnecessary lockfile entries for users of rules_python.

@fmeum
Mark internal deps extension as reproducible
f4b7e94 
This avoids an unnecessary lockfile entry for users of rules_python.
@fmeum fmeum marked this pull request as ready for review May 12, 2024 21:37
@fmeum fmeum requested a review from rickeylev as a code owner May 12, 2024 21:37
@fmeum
Copy link
Contributor Author

fmeum commented May 12, 2024

@aignas Could you review this?

aignas
aignas reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, would love a line in CHANGELOG about the bumped dependency.

It does mean that the rules_python_gazelle_plugin will always have a warning because it depends on 1.3, so maybe we should bump the gazelle/MODULE.bazel as well?

MODULE.bazel Show resolved Hide resolved
@aignas aignas mentioned this pull request May 15, 2024
Merged
@fmeum fmeum requested a review from f0rmiga as a code owner May 16, 2024 08:45
@fmeum fmeum requested a review from aignas May 16, 2024 08:46
@fmeum fmeum changed the title refactor: Mark internal deps extension as reproducible refactor: Mark some extensions as reproducible May 16, 2024
@fmeum fmeum changed the title refactor: Mark some extensions as reproducible refactor: Mark internal and python extension as reproducible May 16, 2024
@fmeum
Copy link
Contributor Author

fmeum commented May 16, 2024 •
edited

I also marked the python extension as reproducible. pip is of course a different story, so I haven't touched it.

@fmeum fmeum mentioned this pull request May 16, 2024
Draft
@aignas aignas added this pull request to the merge queue May 18, 2024
Merged via the queue into bazelbuild:main with commit 45363a1 May 18, 2024
4 checks passed
@betaboon betaboon mentioned this pull request May 18, 2024
Open
@fmeum fmeum deleted the reproducible branch May 19, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@f0rmiga f0rmiga Awaiting requested review from f0rmiga f0rmiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmeum @aignas