crate.select() support
#1977
Merged
crate.select() support
#1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickvanprim
force-pushed
the
annotation_select
branch
from
d635592
to
07e4722
Compare
UebelAndre
previously requested changes
Jun 12, 2023
rickvanprim
force-pushed
the
annotation_select
branch
3 times, most recently
from
b37785a
to
139ff20
Compare
rickvanprim
changed the title
crate.annotation() SelectList/SelectDict supportcrate.select() support
rickvanprim
force-pushed
the
annotation_select
branch
14 times, most recently
from
ee5606f
to
37a6ed2
Compare
There was a problem hiding this comment.
This looks great! I haven't looked thoroughly at the tests in the starlark/select_* files yet, but otherwise this is looking really solid and pretty much ready to merge.
The comments I've labelled "very non-blocking" are "let's talk about whether in the future we should think about this" questions, and definitely not "let's do this in this PR" questions :)
rickvanprim
force-pushed
the
annotation_select
branch
from
37a6ed2
to
bdfe9bf
Compare
|
I've hopefully addressed most things here. Unfortunately hit a few things that need your input. Feel free to make any changes you consider necessary to merge, or I can make them tomorrow 🙂 |
rickvanprim
force-pushed
the
annotation_select
branch
3 times, most recently
from
543835a
to
cde8309
Compare
illicitonion
dismissed
UebelAndre’s stale review
Has been re-implemented and now has good test coverage
… SelectStringDict.
…alue|List|Set|Dict]`.
…t::items()` calls.
…et<T>>`) and changed how `unmapped` is grouped.
rickvanprim
force-pushed
the
annotation_select
branch
from
cde8309
to
becf50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
crate.annotation()to supportcrate.select().Also includes a bunch of hopefully desirable cleanups, like removing the
serialize_starlark()workaround that was no longer necessary.