Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .bazelversion file to always use latest release available. #2323

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 13, 2023

relates to #2317

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 50:50 on this one... I generally like pinning things and having CI be deterministic, but also value testing the latest versions... In an ideal world, I think we'd pin, but have some process which automatically makes an update PR when there are new versions, but I realise that's non-trivial and am not suggesting we build this... WDYT?

@UebelAndre
Copy link
Collaborator Author

I'm 50:50 on this one... I generally like pinning things and having CI be deterministic, but also value testing the latest versions... In an ideal world, I think we'd pin, but have some process which automatically makes an update PR when there are new versions, but I realise that's non-trivial and am not suggesting we build this... WDYT?

I think pinning is good but would rather that be something handled by bazel-ci in general. The pin should be whatever version is either explicitly defined by presubmit.yaml or by the CI environment where ideally before releasing the Bazel team tests all active projects in the bazel org by bumping the pin there and running CI. But as it is now this will get stale and I think we'll get less info than if we allow for the volatile floating pin.

@UebelAndre UebelAndre merged commit 4cdada1 into bazelbuild:main Dec 13, 2023
3 checks passed
@UebelAndre UebelAndre deleted the cleanup branch December 13, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants