cargo-bazel: Corrected sparse registry splicing code #2325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for supporting sparse-registries (private).
Issue:
When we tried to use crate_universe together with an internal sparse registry (Artifactory) we ran into an issue.
cargo-bazel splice
was not correctly detecting sparse registries as "sparse", even though the URLs correctly started with the "sparse+https://" prefix in the Cargo.lock file. Instead it re-interpreted them as registries with a git index.The root cause of this is that
cargo_lock::Lockfile
automatically removes the prefixsparse+
from the URL and the only way to determine that a registry is sparse is to check thekind
. The code previously assumed it could check for sparse registries by checking if the url starts with "sparse+https://".Problem solution:
This pull requests adapts the code so it uses the lockfile "SourceKind" instead of the URL to check if a registry is sparse or not.