Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-bindgen to 0.2.89 #2333

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

alexkirsz
Copy link
Contributor

0.2.88 was yanked.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Can you update docs by running ./docs/update-docs.sh?

@alexkirsz
Copy link
Contributor Author

@UebelAndre Done.

@alexkirsz
Copy link
Contributor Author

@UebelAndre Looks like the instructions in wasm_bindgen/DEVELOPMENT.md are out of date. Not sure how to best update the MODULE.bazel file.

@UebelAndre
Copy link
Collaborator

@matts1 would you know?

@matts1
Copy link
Contributor

matts1 commented Dec 22, 2023

@alexkirsz alexkirsz force-pushed the alexkirsz/update-wasm-bindgen branch from a76754e to 73a50bd Compare January 2, 2024 08:47
@alexkirsz
Copy link
Contributor Author

@UebelAndre I ran the following command as prompted to by the CI build command:



buildozer 'use_repo_add @rules_rust//rust/private:extensions.bzl internal_deps rules_rust_wasm_bindgen__walrus-0.20.3 rules_rust_wasm_bindgen__wasm-bindgen-0.2.89 rules_rust_wasm_bindgen__wasm-bindgen-cli-support-0.2.89 rules_rust_wasm_bindgen__wasm-bindgen-shared-0.2.89' 'use_repo_remove @rules_rust//rust/private:extensions.bzl internal_deps rules_rust_wasm_bindgen__walrus-0.19.0 rules_rust_wasm_bindgen__wasm-bindgen-0.2.88 rules_rust_wasm_bindgen__wasm-bindgen-cli-support-0.2.88 rules_rust_wasm_bindgen__wasm-bindgen-shared-0.2.88' //MODULE.bazel:all

CI is now green :)

@UebelAndre UebelAndre merged commit dd944ed into bazelbuild:main Jan 2, 2024
3 checks passed
@alexkirsz alexkirsz deleted the alexkirsz/update-wasm-bindgen branch January 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants