Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all toolchain files in the current toolchain #2336

Conversation

illicitonion
Copy link
Collaborator

@illicitonion illicitonion commented Dec 15, 2023

rustc assumes it can read things like librustc_driver, and if you don't
include it, it gets sad.

rustc assumes it can read things like librustc_driver, and if you don't
include it, it gets sad.
@illicitonion illicitonion force-pushed the current-rust-toolchain-includes-all-files branch from 35f4a2e to 0aa43fc Compare December 15, 2023 16:55
@illicitonion illicitonion marked this pull request as ready for review December 15, 2023 17:01
@illicitonion illicitonion changed the title Add test for running rustc from toolchain Include all toolchain files in the current toolchain Dec 15, 2023
@illicitonion illicitonion enabled auto-merge (squash) December 15, 2023 17:27
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just had one request 😄

test/toolchain/BUILD.bazel Show resolved Hide resolved
@illicitonion illicitonion merged commit 5ceebc0 into bazelbuild:main Dec 18, 2023
3 checks passed
@illicitonion illicitonion deleted the current-rust-toolchain-includes-all-files branch December 18, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants