Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incompatible_override_toolchain_transition #2344

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

krasimirgg
Copy link
Collaborator

@krasimirgg krasimirgg commented Dec 19, 2023

This has been a no-op since Bazel 5. We're at min Bazel version 6.3.

Not sure if this warrants a rules_rust release. WDYT?

This has been a no-op since Bazel 5. We're at min Bazel version 6.3.
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for us to cut a release if you want, or just to wait until the next one rolls around - I don't see any urgency myself :)

@katre
Copy link
Member

katre commented Dec 19, 2023

I don't think this needs a release, I'm just trying to clean this up now that Bazel 7 is out: bazelbuild/bazel#14127

@UebelAndre
Copy link
Collaborator

@krasimirgg this good to merge?

@krasimirgg
Copy link
Collaborator Author

@krasimirgg this good to merge?

yes!

@krasimirgg krasimirgg merged commit 53830aa into bazelbuild:main Jan 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants