chore: add //bzlmod:hello_world_test and use it as BCR presubmit
#2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matts1
suggested changes
Dec 22, 2023
cgrindel
force-pushed
the
cg/bzlmod_presubmit
branch
from
7f0eb2b
to
fcdf36e
Compare
cgrindel
force-pushed
the
cg/bzlmod_presubmit
branch
from
14ac7d8
to
9f8f044
Compare
cgrindel
force-pushed
the
cg/bzlmod_presubmit
branch
from
0ebe128
to
8b8b66b
Compare
|
@matts1 @illicitonion I removed BTW, the GitHub UI is showing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bzlmod/hello_worldpackage based uponexamples/bzlmod/hello_world.rules_bazel_integration_testso that//bzlmod:hello_world_testcan be executed as a test from the parent workspace.filegrouptargets namedall_filesto collect files for all of the packages that are necessary to userules_rust. These are an input to therules_bazel_integration_testtest..bcr/presubmit.ymlto test//bzlmod:hello_world_test.//bzlmod:hello_world_test.Related to bazelbuild/bazel-central-registry#1199 (comment).