Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include examples/bzlmod in release tgz for BCR presubmit #2379

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Dec 28, 2023

Fixes #2378.

$ tar -czf .github/rules_rust.tar.gz --exclude=".git" --exclude=".github" --exclude="crate_universe/target" examples/bzlmod --exclude="examples" .

$ tar tf .github/rules_rust.tar.gz | rg examples
examples/bzlmod/
examples/bzlmod/hello_world/
examples/bzlmod/hello_world/WORKSPACE.bzlmod
examples/bzlmod/hello_world/hello_world_test.sh
examples/bzlmod/hello_world/.gitignore
examples/bzlmod/hello_world/WORKSPACE.bazel
examples/bzlmod/hello_world/src/
examples/bzlmod/hello_world/src/main.rs
examples/bzlmod/hello_world/BUILD.bazel
examples/bzlmod/hello_world/MODULE.bazel
examples/bzlmod/hello_world/third-party/
examples/bzlmod/hello_world/third-party/Cargo.lock
examples/bzlmod/hello_world/third-party/BUILD.bazel
examples/bzlmod/hello_world/third-party/extension.bzl
examples/bzlmod/hello_world/third-party/crates/
examples/bzlmod/hello_world/third-party/crates/defs.bzl
examples/bzlmod/hello_world/third-party/crates/BUILD.anyhow-1.0.77.bazel
examples/bzlmod/hello_world/third-party/crates/crates.bzl
examples/bzlmod/hello_world/third-party/crates/BUILD.bazel
examples/bzlmod/hello_world/third-party/crates/alias_rules.bzl
examples/bzlmod/hello_world/third-party/Cargo.toml
examples/bzlmod/hello_world/.bazelrc

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit e6a1ee4 into bazelbuild:main Dec 29, 2023
3 checks passed
@dtolnay dtolnay deleted the releasebzlmod branch December 29, 2023 00:55
@csmulhern
Copy link
Contributor

I think we need a 0.36.2 with this change included, in order to get 0.36 into BCR.

@UebelAndre
Copy link
Collaborator

I think we need a 0.36.2 with this change included, in order to get 0.36 into BCR.

I created #2382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BCR presubmit is failing, examples/bzlmod/hello_world does not exist
4 participants