-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cross-compiling with bzlmod possible, added example #2419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! Just one question about testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@illicitonion any chance of landing this? |
LGTM, thanks! If you can rebase (or open up permissions so I can update the branch), happy to merge! |
Before it wasn't possible to add your desired cross-compilation targets to
extra_target_triples
if they also happened to be inDEFAULT_TOOLCHAIN_TRIPLES
.