Add script to revendor all crates #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested changes
Feb 16, 2024
cameron-martin
force-pushed
the
revendor-crates
branch
2 times, most recently
from
8c1c3b8
to
eb2a060
Compare
It seems that vendored crates commonly get out of sync. Re-vendoring seems to currently be a quite manual process, and finding everything to re-vendor is a hassle. This adds a bash script, `vendor.sh`, that finds all crate vendor rules in all workspaces in this repository and runs them. This significantly improves the workflow for updating these.
cameron-martin
force-pushed
the
revendor-crates
branch
from
eb2a060
to
61dc4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that vendored crates commonly get out of sync. Re-vendoring seems to currently be a quite manual process, and finding everything to re-vendor is a hassle.
This adds a bash script,
vendor.sh, that finds all crate vendor rules in all workspaces in this repository and runs them. This significantly improves the workflow for updating these.This also adds
.bazelrcfiles to disable bzlmod to non-bzlmod workspaces, since otherwise bazel 7 create a MODULE.bazel and MODULE.bazel.lock when re-vendoring.This also re-vendors all crates (in a separate commit).