Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @rules_testing for Starlark tests #2480

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

daivinhtran
Copy link
Contributor

This is a follow-up PR of #2422.

I'm scoping it to a separate PR to introduce @rules_testing (a new Starlark testing framework). The framework removes a lot of boilerplate code (unncessarily) required when writing analysis tests.

@daivinhtran daivinhtran changed the title Introduce @rules_testing to write Starlark tests Introduce @rules_testing for Starlark tests Feb 16, 2024
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems totally fine to me! I think if we want to introduce this it'd be good to do so in a change that converts more so we can get a better sense of the practical improvement the new framework offers to the repo.

@daivinhtran
Copy link
Contributor Author

it'd be good to do so in a change that converts more

That's a good idea. I'll hold on to this PR until I convert a few more tests to surface the differences more clearly.

@daivinhtran
Copy link
Contributor Author

Since I need to use rules_testing to write tests for #2414, I'll go ahead and merge the PR. I'll follow-up with converting a few more tests to rules_testing before we introduce it more broadly.

@daivinhtran daivinhtran added this pull request to the merge queue Feb 19, 2024
Merged via the queue into bazelbuild:main with commit 184da7d Feb 19, 2024
3 checks passed
qtica added a commit to qtica/rules_rust that referenced this pull request Apr 1, 2024
This is a follow-up PR of
bazelbuild#2422.

I'm scoping it to a separate PR to introduce
[@rules_testing](https://github.com/bazelbuild/rules_testing) (a new
Starlark testing framework). The framework removes a lot of boilerplate
code (unncessarily) required when writing analysis tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants