-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce @rules_testing for Starlark tests #2480
Introduce @rules_testing for Starlark tests #2480
Conversation
f074e98
to
5802697
Compare
5802697
to
d641b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seems totally fine to me! I think if we want to introduce this it'd be good to do so in a change that converts more so we can get a better sense of the practical improvement the new framework offers to the repo.
That's a good idea. I'll hold on to this PR until I convert a few more tests to surface the differences more clearly. |
978bb3d
to
2211293
Compare
Since I need to use |
This is a follow-up PR of bazelbuild#2422. I'm scoping it to a separate PR to introduce [@rules_testing](https://github.com/bazelbuild/rules_testing) (a new Starlark testing framework). The framework removes a lot of boilerplate code (unncessarily) required when writing analysis tests.
This is a follow-up PR of #2422.
I'm scoping it to a separate PR to introduce @rules_testing (a new Starlark testing framework). The framework removes a lot of boilerplate code (unncessarily) required when writing analysis tests.