Allow rules to provide their own rust-analyzer providers #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
rust-analyzer
branch
2 times, most recently
from
ad6f2a1
to
f58827d
Compare
UebelAndre
force-pushed
the
rust-analyzer
branch
from
f58827d
to
1853660
Compare
auto-merge was automatically disabled
February 19, 2024 11:12
Merge queue setting changed
illicitonion
approved these changes
Feb 20, 2024
qtica
added a commit
to qtica/rules_rust
that referenced
this pull request
Apr 1, 2024
…2487) This change cleans up the rust-analyzer aspect to support external rules providing their own crate specs. For now only prost implements behavior for this and the rust-analyzer interface is still private. In the future if this proves to be performant and a consistent interface then there should be no issue making this a public part of the `//rust` package. This change incorporates bazelbuild#1875 (special thanks to @snowp!) and addresses performance issues in the generator tool by allowing users of `bazelisk` to ensure their `tools/bazel` scripts run should one be provided and to disable running validation actions when building crate specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up the rust-analyzer aspect to support external rules providing their own crate specs. For now only prost implements behavior for this and the rust-analyzer interface is still private. In the future if this proves to be performant and a consistent interface then there should be no issue making this a public part of the
//rustpackage.This change incorporates #1875 (special thanks to @snowp!) and addresses performance issues in the generator tool by allowing users of
bazeliskto ensure theirtools/bazelscripts run should one be provided and to disable running validation actions when building crate specs.