Introduce rules_rust_unsupported_feature #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a special sentinel feature name to the UNSUPPORTED_FEATURES list. This feature name can be used by authors of C++ toolchain configurations to house any configuration fragments (e.g., linker flags) that should NOT be applied when linking Rust targets. The specific motivation for this is that I'm working on a project that includes `-fsanitize=address` in its clang configuration. This needs to be disabled when linking Rust. I tried the more straightforward approach of adding the `features` attribute to `rust_binary` targets in my repo, but this is not sufficient: a `rust_binary` has implicit deps on targets like @rules_rust//util/process_wrapper:bootstrap_process_wrapper.
qtica
added a commit
to qtica/rules_rust
that referenced
this pull request
Apr 1, 2024
Add a special sentinel feature name to the UNSUPPORTED_FEATURES list. This feature name can be used by authors of C++ toolchain configurations to house any configuration fragments (e.g., linker flags) that should NOT be applied when linking Rust targets. The specific motivation for this is that I'm working on a project that includes `-fsanitize=address` in its clang configuration. This needs to be disabled when linking Rust. I tried the more straightforward approach of adding the `features` attribute to `rust_binary` targets in my repo, but this is not sufficient: a `rust_binary` has implicit deps on targets like @rules_rust//util/process_wrapper:bootstrap_process_wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a special sentinel feature name to the UNSUPPORTED_FEATURES list. This feature name can be used by authors of C++ toolchain configurations to house any configuration fragments (e.g., linker flags) that should NOT be applied when linking Rust targets.
The specific motivation for this is that I'm working on a project that includes
-fsanitize=addressin its clang configuration. This needs to be disabled when linking Rust.I tried the more straightforward approach of adding the
featuresattribute torust_binarytargets in my repo, but this is not sufficient: arust_binaryhas implicit deps on targets like @rules_rust//util/process_wrapper:bootstrap_process_wrapper.