Split CrateID CrateNameAndVersionReq #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
approved these changes
Feb 28, 2024
Currently we use the same CrateId type for two contexts: A known crate name + version, and in an annotation to specify a version requirement that an annotation applies to. These are different use-cases, and neither should use String to represent a the version.
This will be important because semver::Version doesn't have a default impl.
illicitonion
force-pushed
the
split-crateid-cratenameandversionreq
branch
from
7010b83
to
7f1f4fc
Compare
qtica
added a commit
to qtica/rules_rust
that referenced
this pull request
Apr 1, 2024
Currently we use the same CrateId type for two contexts: A known crate name + version, and in an annotation to specify a version requirement that an annotation applies to. These are different use-cases, and neither should use String to represent a the version. Also, update CrateId to use a `semver::Version` (which is required, not optional).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the same CrateId type for two contexts: A known crate
name + version, and in an annotation to specify a version requirement
that an annotation applies to.
These are different use-cases, and neither should use String to
represent a the version.
Also, update CrateId to use a
semver::Version(which is required, not optional).