Keep default_features parity from bzlmod to workspace #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Targeted at fixing #2595 |
illicitonion
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Thanks for your contribution! This PR looks good to me, but can you add a test so we don't regress this behaviour in the future? Maybe add another dep to https://github.com/bazelbuild/rules_rust/tree/main/examples/bzlmod/hello_world_no_cargo, and write a small rust file which consumes the dep and would fail to compile if default features weren't enabled?
|
Glad I could contribute to OSS I depend on :) Added the test, let me know any follow-ups too |
illicitonion
approved these changes
Apr 9, 2024
rrbutani
pushed a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
Apr 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_rust](https://togithub.com/bazelbuild/rules_rust) | http_archive | minor | `0.41.1` -> `0.42.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.42.0`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.42.0) [Compare Source](https://togithub.com/bazelbuild/rules_rust/compare/0.41.1...0.42.0) ### 0.42.0 ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-XT1YVJ6FHJTXBr1v3px2fV37/OCS3dQk3ul+XvfIIf8=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.42.0/rules_rust-v0.42.0.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Fix crates.io URL by [@​ericmcbride](https://togithub.com/ericmcbride) in [bazelbuild/rules_rust#2597 - Add support for `--compile_one_dependency` by [@​william-smith-skydio](https://togithub.com/william-smith-skydio) in [bazelbuild/rules_rust#2598 - Update rules_apple by [@​sgowroji](https://togithub.com/sgowroji) in [bazelbuild/rules_rust#2602 - Support building more things with bzlmod by [@​matts1](https://togithub.com/matts1) in [bazelbuild/rules_rust#2601 - Make bazel lock file cross-platform by [@​cameron-martin](https://togithub.com/cameron-martin) in [bazelbuild/rules_rust#2453 - Added Rust 1.77.1 by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2591 - Fix (+) In vendored crates semver metadata by [@​ericmcbride](https://togithub.com/ericmcbride) in [bazelbuild/rules_rust#2579 - Keep default_features parity from bzlmod to workspace by [@​Lev1ty](https://togithub.com/Lev1ty) in [bazelbuild/rules_rust#2606 - clippy: use --cap-lints=warn; apply clippy_flags when capture_output=True by [@​goffrie](https://togithub.com/goffrie) in [bazelbuild/rules_rust#2451 - Added Rust 1.77.2 by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2608 - Re-vendor crate_universe outputs by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2609 - Release 0.42.0 by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2610 #### New Contributors - [@​Lev1ty](https://togithub.com/Lev1ty) made their first contribution in [bazelbuild/rules_rust#2606 **Full Changelog**: bazelbuild/rules_rust@0.41.1...0.42.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
crate.specdefault_featurestoTrueasWORKSPACEhandles it.default_featuresduring package json encoding as both truthy and falsy values for booleans are significant.