Remove swift_usage_aspect and SwiftUsageInfo #1138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
referenced
this pull request
Nov 17, 2023
…rules_apple. With the toolchain information removed, this aspect/provider offers a minimal API. The only client is rules_apple, which uses it to determine if Swift support may need to be bundled at all, so it's better that that single client own it, rather than rules_swift try to provide an API that could serve all possible hypothetical clients. PiperOrigin-RevId: 439577534
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
Cherry-picked from commit: c24a84a > With the toolchain information removed, this aspect/provider offers a minimal API. > The only client is rules_apple, which uses it to determine if Swift support may need to be bundled at all, so it's better that that single client own it, rather than rules_swift try to provide an API that could serve all possible hypothetical clients.
luispadron
force-pushed
the
luis/cherry-pick-c24a84a
branch
from
fb597c6
to
5174211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from commit: c24a84a