Upgrade grpc-swift to 1.21.1 #1185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-the-dev
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
kev-the-dev
force-pushed
the
kev-the-dev/1.16.0-grpc-upgrade
branch
from
40ae047
to
a6f3e68
Compare
|
Standby, working on figuring out the appropriate way to submit the CLA |
kev-the-dev
force-pushed
the
kev-the-dev/1.16.0-grpc-upgrade
branch
from
a6f3e68
to
8a3b214
Compare
|
CLA complete and passed |
|
Hey, @kev-the-dev. Can you provide more detail on the PR description about why you're doing this update? And can you fix the failing CI jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade grpc-swift to 1.21.1, along with some of its transitive dependencies. This new version contains bug fixes and and access to new APIs, such as the GRPCChannelPoolError struct being publicly exported. The versions of these transitive dependencies were pulled directly from grpc-swift's package.swift.
This also required some changes to the grpc-swift build overlay, since grpc-swift split up into some sub-libraries instead of one monolith library. This was done iteratively, adding in these new libraries until the grpc-swift build passed.
Testing
In a project, can build swift packages which use grpc and make use of new features in this version of grpc-swift.