Tune chromatic #11398
Closed
Tune chromatic #11398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
approved these changes
Mar 15, 2024
andrewscfc
commented
Mar 15, 2024
| @@ -24,6 +24,11 @@ export default { | |||
| Component, | |||
| title: 'Pages/Media Asset Page', | |||
| decorators: [story => <WithTimeMachine>{story()}</WithTimeMachine>], | |||
| parameters: { | |||
| chromatic: { | |||
| delay: 15000, | |||
There was a problem hiding this comment.
Hmm this doesn't seem to have helped as the flake is showing up on this PR still; should I revert this change?
amoore108
approved these changes
Mar 18, 2024
|
Think this can be closed @andrewscfc ? |
happy to close 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #10866, this PR tunes our snapshots a bit more by:
Testing
Merge and see if flakes for associated stories stop occuring
Helpful Links
Coding Standards
Repository use guidelines