-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spikes/korean downloads #11594
base: latest
Are you sure you want to change the base?
Spikes/korean downloads #11594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions, but looks good 👍
@@ -62,7 +62,7 @@ | |||
"test:e2e": "yarn stop && yarn build && run-p --race start cypress", | |||
"test:e2e:interactive": "yarn stop && yarn build && run-p --race start cypress:interactive", | |||
"test:lint": "eslint --ext .js,jsx,json,ts,tsx ./src ./data ./cypress ./.storybook ./webpack**", | |||
"test:lint:fix": "eslint --fix --ext .js,jsx,json,ts,tsx ./src ./data ./cypress ./.storybook ./webpack**", | |||
"test:lint:fix": "eslint --fix --ext .js,jsx,json,ts,tsx ./src ./data ./ws-nextjs-app/pages ./cypress ./.storybook ./webpack**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you 👍
ws-nextjs-app/pages/[service]/downloads/downloadsPageLayout.tsx
Outdated
Show resolved
Hide resolved
translations: { | ||
downloads?: { | ||
instructions = 'You can download and view today’s news.', | ||
title = 'File Download', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations: { | |
downloads?: { | |
instructions = 'You can download and view today’s news.', | |
title = 'File Download', | |
}, | |
}, | |
translations: { | |
downloads: { | |
instructions = 'You can download and view today’s news.', | |
title = 'File Download', | |
} = {}, | |
}, |
import styles from './styles'; | ||
import { PageProps } from './types'; | ||
|
||
const downloadsPageLayout = ({ service, pageData }: PageProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be DownloadsPageLayout
(capital D) to make it a valid React component.
poc