Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(WSTEAMA-1180): update topicPage tests to not use BFF #11621

Merged
merged 1 commit into from
May 14, 2024

Conversation

karinathomasbbc
Copy link
Collaborator

Resolves JIRA [WSTEAMA-1180]

Overall changes

Refactor and stabilise tests for topic page.

Code changes

  1. Removed cy.getPageData function and replaced it with getPageDataFromWindow
  2. Used window.SIMORGH_DATA.pageData for canonical tests
  3. Unskipped test
  4. Added a BeforeEach() function, to ensure we always start from the path being tested and make the tests deterministic

Testing

  • Cypress Tests on PR passing
Environment Smoke Command Status
local true CYPRESS_APP_ENV=local CYPRESS_SMOKE=true yarn test:e2e  N/A
local false CYPRESS_APP_ENV=local yarn test:e2e  N/A
test true CYPRESS_APP_ENV=test CYPRESS_SMOKE=true yarn cypress  Pass
test false CYPRESS_APP_ENV=test yarn cypress  Pass
live true CYPRESS_APP_ENV=live CYPRESS_SMOKE=true yarn cypress  Pass
live false CYPRESS_APP_ENV=live yarn cypress  Pass

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@MeriemMechri MeriemMechri force-pushed the tests/stabilise-topics-page branch 2 times, most recently from 51502d1 to 82fb2ee Compare May 14, 2024 10:38
Copy link
Collaborator Author

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve as I opened this PR, but I approve in principle!!

@MeriemMechri MeriemMechri force-pushed the tests/stabilise-topics-page branch 2 times, most recently from 772c1b4 to 32d33d2 Compare May 14, 2024 14:19
test(WESTEAMA-1180): update topicPage tests to not use BFF

remove async/await as it causes issues on CI

disable topicPage test for kyrgyz
@MeriemMechri MeriemMechri merged commit 8d0e147 into latest May 14, 2024
11 checks passed
@MeriemMechri MeriemMechri deleted the tests/stabilise-topics-page branch May 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants