Remove placeholder image from billboard #11625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the behaviour of the MaskedImage elsewhere (e.g. on live page)
karinathomasbbc
commented
May 14, 2024
| @@ -14,11 +14,13 @@ const MaskedImage = ({ | |||
| imageUrlTemplate, | |||
| imageWidth, | |||
| altText = '', | |||
| showPlaceholder = true, | |||
There was a problem hiding this comment.
I wonder if this should be defaulted to true or not. The default for the Image component is true so an undefined value will become true... 🤔
There was a problem hiding this comment.
I think its ok to have it default to true here since it has been true anyway as you say.
shayneahchoon
approved these changes
May 14, 2024
amoore108
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
Removes the background / placeholder image from the billboard when the image is transparent
Before:
Code changes
placeholderfrom Billboard -> MaskedImage - Image componentAfter:
Testing