Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package-lock to remove minimist vulnerability #5997

Merged
merged 19 commits into from Apr 6, 2020
Merged

Update package-lock to remove minimist vulnerability #5997

merged 19 commits into from Apr 6, 2020

Conversation

j-pendlebury
Copy link
Contributor

@j-pendlebury j-pendlebury commented Mar 26, 2020 •
edited

Part of #5905

Overall change:
Removed and re-generated package-lock to pull in latest dependencies to remove minimist vulnerability.

Code changes:

  • Removed and re-generated package-lock
  • Updated snapshots
  • Updated bulletin component test
  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@j-pendlebury j-pendlebury self-assigned this Mar 26, 2020
@j-pendlebury j-pendlebury added ws-home ws-media World Service Media ws-articles Tasks for the WS Articles Team dependencies labels Mar 26, 2020
@j-pendlebury j-pendlebury added this to PR in Progress in Simorgh via automation Mar 26, 2020
@j-pendlebury j-pendlebury marked this pull request as ready for review April 2, 2020 16:03
@j-pendlebury
Copy link
Contributor Author

j-pendlebury commented Apr 2, 2020 •
edited

There are 2 vulnerabilities left which will be fixed by #5976, afterwards #5905 can be completed by removing npm audit whitelist from package.json

@j-pendlebury j-pendlebury moved this from PR in Progress to Code review in Simorgh Apr 2, 2020
Bopchy
Bopchy approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

EinsteinNjoroge
EinsteinNjoroge approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Simorgh automation moved this from Code review to Ready for Test Apr 3, 2020
@PriyaKR PriyaKR moved this from Ready for Test to In Test in Simorgh Apr 6, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Apr 6, 2020

Looks good to me.

@PriyaKR PriyaKR self-assigned this Apr 6, 2020
@PriyaKR PriyaKR moved this from In Test to Ready for merge (probably) in Simorgh Apr 6, 2020
@amywalkerdev amywalkerdev merged commit b8159df into latest Apr 6, 2020
Simorgh automation moved this from Ready for merge (probably) to Done Apr 6, 2020
@amywalkerdev amywalkerdev deleted the minimist-update branch April 6, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bopchy Bopchy Bopchy approved these changes

@EinsteinNjoroge EinsteinNjoroge EinsteinNjoroge approved these changes

Assignees

@PriyaKR PriyaKR

@j-pendlebury j-pendlebury

Labels
dependencies ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@j-pendlebury @PriyaKR @Bopchy @EinsteinNjoroge @amywalkerdev