Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #6128

Merged
merged 23 commits into from Apr 16, 2020
Merged

Update dependencies #6128

merged 23 commits into from Apr 16, 2020

Conversation

j-pendlebury
Copy link
Contributor

@j-pendlebury j-pendlebury commented Apr 7, 2020 •
edited

Resolves #5814

Overall change:
Updated dependencies:

  1. "@bbc/psammead-section-label": "^5.0.2 => ^5.0.3"
  2. "@testing-library/dom": "^7.2.0 => ^7.2.1"
  3. "chalk": "^3.0.0 => ^4.0.0"
  4. "eslint-plugin-react-hooks": "^2.5.1 => ^3.0.0"
  5. "jest": "^25.2.6 => 25.2.7"
  6. "lint-staged": "^10.1.1 => ^10.1.2"
  7. "prettier": "^2.0.2 => ^2.0.4"
  8. "stylelint": "^13.2.1 => ^13.3.0"

Code changes:

  • Updated dependecies
  • Removed acorn from npm audit whitelist since
  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@j-pendlebury j-pendlebury self-assigned this Apr 7, 2020
@j-pendlebury j-pendlebury added dependencies ws-home ws-media World Service Media ws-articles Tasks for the WS Articles Team labels Apr 7, 2020
@j-pendlebury j-pendlebury added this to PR in Progress in Simorgh via automation Apr 7, 2020
@j-pendlebury j-pendlebury marked this pull request as ready for review April 7, 2020 16:13
@j-pendlebury j-pendlebury moved this from PR in Progress to Code review in Simorgh Apr 7, 2020
Bopchy
Bopchy suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test snapshots need to be updated.

Simorgh automation moved this from Code review to PR in Progress Apr 8, 2020
@j-pendlebury j-pendlebury moved this from PR in Progress to Code review in Simorgh Apr 15, 2020
FK78
FK78 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@FK78 FK78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Simorgh automation moved this from Code review to Ready for Test Apr 16, 2020
@PriyaKR PriyaKR moved this from Ready for Test to In Test in Simorgh Apr 16, 2020
@PriyaKR PriyaKR moved this from In Test to Ready for Test in Simorgh Apr 16, 2020
@PriyaKR PriyaKR moved this from Ready for Test to In Test in Simorgh Apr 16, 2020
@PriyaKR PriyaKR assigned PriyaKR and j-pendlebury and unassigned j-pendlebury Apr 16, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Apr 16, 2020

LGTM.

@PriyaKR PriyaKR moved this from In Test to Ready for merge (probably) in Simorgh Apr 16, 2020
@amywalkerdev amywalkerdev merged commit b54d1d6 into latest Apr 16, 2020
@amywalkerdev amywalkerdev deleted the dep-updates branch April 16, 2020 15:26
Simorgh automation moved this from Ready for merge (probably) to Done Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tochwill tochwill tochwill approved these changes

@Bopchy Bopchy Bopchy approved these changes

@FK78 FK78 FK78 approved these changes

Assignees

@PriyaKR PriyaKR

@j-pendlebury j-pendlebury

Labels
dependencies ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove npm audit whitelisted package - Acorn
7 participants
@j-pendlebury @PriyaKR @tochwill @Bopchy @FK78 @amywalkerdev @12