Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greenkeeper/styled components 4.1.1 #937

Closed
wants to merge 3 commits into from
Closed

Greenkeeper/styled components 4.1.1 #937

wants to merge 3 commits into from

Conversation

jtart
Copy link
Contributor

@jtart jtart commented Nov 13, 2018

Updates styled-components to 4.1.1` via Greenkeeper

@jtart jtart mentioned this pull request Nov 13, 2018
Closed
@jtart jtart added this to PR In Progress in News Article Nov 13, 2018
@pjlee11
Copy link
Contributor

pjlee11 commented Nov 14, 2018 •
edited

To stabilise this PR we need to move from injectGlobal to createGlobalStyle in our globalStyles.js

Further details in this blog post

@jtart jtart added the external blocked Blocked by an external dependency label Nov 19, 2018
@jtart
Copy link
Contributor Author

jtart commented Nov 19, 2018

This is blocked by styled-components/jest-styled-components#191.

@jtart jtart closed this Nov 20, 2018
News Article automation moved this from PR In Progress to Done Nov 20, 2018
@jtart jtart deleted the greenkeeper/styled-components-4.1.1 branch November 20, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external blocked Blocked by an external dependency
Projects
No open projects
News Article
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtart @pjlee11