Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #392 #405

Closed
wants to merge 1 commit into from
Closed

Fix for #392 #405

wants to merge 1 commit into from

Conversation

apla
Copy link

@apla apla commented Apr 7, 2019

Allows using with jasmine --reporter=jasmine-spec-reporter

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #405   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         416    418    +2     
  Branches       36     36           
=====================================
+ Hits          416    418    +2
Impacted Files Coverage Δ
src/main.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c316c3...a8b04de. Read the comment docs.

@piecioshka
Copy link

@bcaudan please merge 🙏

@bcaudan
Copy link
Owner

bcaudan commented Apr 21, 2019

I have tested it locally without success.

exports.default does not seem to be equivalent to module.exports.
Am I missing something?

@bcaudan bcaudan closed this Jun 19, 2019
@piecioshka
Copy link

Eh @bcaudan why you don't merge?

@bcaudan
Copy link
Owner

bcaudan commented Jun 20, 2019

Hi @piecioshka, as I said in the previous comment, I have not been able to make it work and add some thoughts on the original issue: #392 (comment)
Due to the lack of activity, I decided to close this PR.
I would be glad to reopen it if someone make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants