Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colors/safe #538

Merged
merged 3 commits into from Sep 20, 2020
Merged

Use colors/safe #538

merged 3 commits into from Sep 20, 2020

Conversation

bcaudan
Copy link
Owner

@bcaudan bcaudan commented Sep 19, 2020

Motivation

fixes #528, avoid string prototype pollution

Changes

  • use colors/safe
  • introduce theme class to apply theme to string
  • remove prototype pollution from specs

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #538 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          16       16           
  Lines         500      518   +18     
  Branches       69       70    +1     
=======================================
+ Hits          499      517   +18     
  Misses          1        1           
Impacted Files Coverage Δ
src/display/execution-display.ts 100.00% <ø> (ø)
src/configuration-parser.ts 100.00% <100.00%> (ø)
src/display-processor.ts 100.00% <100.00%> (ø)
src/display/summary-display.ts 100.00% <100.00%> (ø)
src/processors/default-processor.ts 100.00% <100.00%> (ø)
src/processors/pretty-stacktrace-processor.ts 97.56% <100.00%> (ø)
src/processors/spec-colors-processor.ts 100.00% <100.00%> (ø)
src/spec-reporter.ts 100.00% <100.00%> (ø)
src/theme.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa2cef...fb03cb5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor request: Use colors/safe
1 participant