Use pnpm instead of npm #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurensgroeneveld
force-pushed
the
switch-to-pnpm
branch
from
59d3efa
to
c61461e
Compare
|
Unfortunately a Storybook issue currently prevents this from going through 😔 See storybookjs/builder-vite#141 - upgrading to Storybook v7 should solve this, but first we're going to investigate moving to Histoire in #39, so let's wait on a conclusion on that before moving forward with this. Closing this PR for now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since other projects use
pnpminstead ofnpmas well, and it's on adopt in the Technology Radar, we want to make the switch as well to have a uniform landscape in BCC. Besides that it has speed benefits and, a personal pet peeve of mine, we no longer need to usenpm ciwhich doesn't respect cache properly so we need to do some tricks in CI.