Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates, electron config updates (v24) #165

Merged
merged 10 commits into from Jul 6, 2023
Merged

Conversation

SimonSimCity
Copy link
Collaborator

@SimonSimCity SimonSimCity commented Jul 3, 2023

Not easy to see in the summary: I've updated many packages and also removed the package electron-builder-notarize, because electron-builder (since v24) already ships its own notarization tool - @electron/notarize

Pinning typescript version to 5.x fixes vuejs/language-tools#2190

@env0
Copy link

env0 bot commented Jul 3, 2023

🚀  env0 had composed a PR Plan for environment bmm-prod / bmm-services-prod :

No changes. Infrastructure is up-to-date.
There are no cost estimation changes

Full PR Plan logs on env0

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #165 (4d13ed9) into main (d02d951) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d13ed9 differs from pull request most recent head 9522a6c. Consider uploading reports for the commit 9522a6c to get more accurate results

@@            Coverage Diff            @@
##              main      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           77        77           
  Branches         6         6           
=========================================
  Hits            77        77           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SimonSimCity SimonSimCity temporarily deployed to prod July 3, 2023 08:49 — with GitHub Actions Inactive
@SimonSimCity SimonSimCity temporarily deployed to prod July 3, 2023 09:32 — with GitHub Actions Inactive
@SimonSimCity SimonSimCity mentioned this pull request Jul 3, 2023
@SimonSimCity SimonSimCity temporarily deployed to prod July 3, 2023 14:45 — with GitHub Actions Inactive
@@ -56,4 +56,12 @@ export default defineNuxtConfig({
colorMode: {
classSuffix: "",
},
// TODO: Option is marked as invalid if env ELECTRON is not enabled, because this enables the module which allows the configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I understand this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt generates types, specially those for the valid nuxt-config. If the module nuxt-electron is loaded, the config property electron is allowed. If its not added (when the env ELECTRON is falsy), this property is not valid. Means when running pnpm dev, your ide will show it as wrong, same as when running nuxi typecheck. You need to set the env ELECTRON as truthy for the types to match. See f492f60, where this comment was added.

# Conflicts:
#	package.json
#	pnpm-lock.yaml
@SimonSimCity SimonSimCity temporarily deployed to prod July 6, 2023 07:29 — with GitHub Actions Inactive
@SimonSimCity SimonSimCity merged commit 59f9fa4 into main Jul 6, 2023
9 checks passed
@SimonSimCity SimonSimCity deleted the package-updates branch July 6, 2023 07:59
@SimonSimCity SimonSimCity temporarily deployed to prod July 6, 2023 07:59 — with GitHub Actions Inactive
SimonSimCity added a commit that referenced this pull request Jul 6, 2023
Left over from #165 where packages were updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In vue components, if a symbol is imported from 'vue' module, additional imports are not auto-completed.
2 participants