New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package updates, electron config updates (v24) #165
Conversation
c044170
to
5a06b0e
Compare
🚀 env0 had composed a PR Plan for environment bmm-prod / bmm-services-prod :
|
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 77 77
Branches 6 6
=========================================
Hits 77 77 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -56,4 +56,12 @@ export default defineNuxtConfig({ | |||
colorMode: { | |||
classSuffix: "", | |||
}, | |||
// TODO: Option is marked as invalid if env ELECTRON is not enabled, because this enables the module which allows the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if I understand this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nuxt generates types, specially those for the valid nuxt-config. If the module nuxt-electron
is loaded, the config property electron
is allowed. If its not added (when the env ELECTRON
is falsy), this property is not valid. Means when running pnpm dev
, your ide will show it as wrong, same as when running nuxi typecheck
. You need to set the env ELECTRON
as truthy for the types to match. See f492f60, where this comment was added.
# Conflicts: # package.json # pnpm-lock.yaml
Left over from #165 where packages were updated
Not easy to see in the summary: I've updated many packages and also removed the package
electron-builder-notarize
, becauseelectron-builder
(since v24) already ships its own notarization tool -@electron/notarize
Pinning typescript version to 5.x fixes vuejs/language-tools#2190