Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume control & draggable sliders #421

Merged
merged 13 commits into from
May 16, 2024
Merged

Volume control & draggable sliders #421

merged 13 commits into from
May 16, 2024

Conversation

kkuepper
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

andreasgangso
andreasgangso requested changes May 14, 2024
View reviewed changes
Copy link
Member

@andreasgangso andreasgangso left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt read detailed but id refactor into a reusable slider component instead of embedding it inside the mediaplayer.

also consider https://zagjs.com/components/vue-sfc/slider for some free functionality and accessibility (zag is modular, pnpm install this and import)

@kkuepper
Copy link
Member Author

I looked at different sliders but didn't like them for different reasons. But the slider from zag looks really good. I'll refactor to use it.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

andreasgangso
andreasgangso requested changes May 15, 2024
View reviewed changes
Copy link
Member

@andreasgangso andreasgangso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

components/media-player/PositionSlider.vue Show resolved Hide resolved
plugins/mediaPlayer/mediaPlayer.ts Show resolved Hide resolved
components/media-player/PositionSlider.vue Show resolved Hide resolved
components/media-player/VolumeSlider.vue Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-421.westeurope.3.azurestaticapps.net

@kkuepper kkuepper merged commit 9b2b8d8 into main May 16, 2024
11 checks passed
@kkuepper kkuepper deleted the feature/314_volume-control branch May 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasgangso andreasgangso andreasgangso requested changes

@SimonSimCity SimonSimCity Awaiting requested review from SimonSimCity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkuepper @andreasgangso