Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e testing #58

Merged
merged 13 commits into from
Apr 17, 2023
Merged

Added e2e testing #58

merged 13 commits into from
Apr 17, 2023

Conversation

SimonSimCity
Copy link
Collaborator

@SimonSimCity SimonSimCity commented Apr 12, 2023

Added a foundation of e2e testing. Please give feedback!

How variables can be set can be found here: https://docs.cypress.io/guides/guides/environment-variables#Setting

I've added the two currently in use (USERNAME and PASSWORD) already to the github-script which should already work correctly after setting 'em up.

The build_and_test job fails because of the missing credentials.

We should also address here if we want the project to deploy if the e2e tests are failing due to a shift in data (e.g. test-data is not available as expected) or if the login service is unavailable or doesn't let us pass for other reasons.

@kkuepper
Copy link
Member

I added the 2 secrets.
But the build fails in the linter step

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #58 (4bb166b) into main (75e75f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           71        71           
  Branches         5         5           
=========================================
  Hits            71        71           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -0,0 +1,37 @@
/// <reference types="cypress" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file be committed? Looks like a left-over

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet fully understood what the code-examples here are for - they're provided by the code generator. I'd commit it as part of understanding of what we can do, but I don't have any strong opinion on this ... What would you say is better?

Btw, the first line is a so-called triple-slash directive

@SimonSimCity
Copy link
Collaborator Author

It seems like within github-actions, we have a problem reaching out to localhost as described in cypress-io/github-action#802 ... Testing out different strategies to see which may get it to work without switching from the name localhost ... Or we'll have to change the addresses allowed by for the auth0 credentials.

@SimonSimCity
Copy link
Collaborator Author

Problem referenced previously (regarding localhost) isn't relevant here. After watching the video of the test, I saw that there's a problem with the test-user we have, which should be solved by our login service.

Videos and screenshots of tests are from now on available as artifacts on this project (!to everyone!). Steps for typing in credentials or confidential data should have the option log set to false: https://stackoverflow.com/questions/50568526/is-there-any-way-to-hide-a-log-in-cypress

@SimonSimCity SimonSimCity merged commit 46542f7 into main Apr 17, 2023
5 checks passed
@SimonSimCity SimonSimCity deleted the e2e branch April 17, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants