Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly parse and set PreferredAEADCipherSuites subpacket #1464

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vanitasvitae
Copy link
Contributor

In #1410 I apparently forgot to change some places away from PreferredAlgorithms to PreferredAEADCiphersuites.

This PR fixes these cases.

@dghgit
Copy link
Contributor

dghgit commented Aug 11, 2023

Would you deprecate the current methods and add setPreferredAEADCiphersuites and getPreferredAEADCiphersuites instead? Thanks to the latest GPG role out a lot of people seem to be using AEAD now - I think it's too late to break the API on this one, there's going to be a lot of third party code depending on the current methods.

@vanitasvitae
Copy link
Contributor Author

vanitasvitae commented Aug 11, 2023

Sure, I can change that :)
It is kind of fitting, that the old preferences packet type (here called Preferred Encryption Modes) was deprecated in GnuPGs branch of the specification as well: https://www.ietf.org/archive/id/draft-koch-openpgp-2015-rfc4880bis-02.html#name-preferred-encryption-modes

Edit: I reintroduced the old methods and added a disclaimer about their deprecation.
I also re-added the GnuPG-style PREFERRED_ENCRYPTION_MODES algorithm preferences subpacket type.

@vanitasvitae
Copy link
Contributor Author

Let me add some more tests for this, so that we can be sure that both methods are not interfering with another.

@vanitasvitae vanitasvitae marked this pull request as draft April 30, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants