Feature/wd3691 #36
Merged
Feature/wd3691 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // import red from '@mui/material/colors/red'; | ||
|
|
||
| // Callbacks can have any number of arguments and can have any return type. | ||
| interface IProps { |
There was a problem hiding this comment.
I though we weren't using Typescript for this app?
There was a problem hiding this comment.
We're using it for the frontend only. I think the discussion around TS was for the backend
There was a problem hiding this comment.
pretty sure it was the whole app. we havent had a chance to all come together to hash this out yet. maybe we need a developer coffee before the next scheduled one.
There was a problem hiding this comment.
@ShawnTurple is this true?
There was a problem hiding this comment.
We are using ts in the frontend only
ASpiteri-BCGov
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial PR. What is to come for this feature branch:
This PR is a little on the large side. Basically this comes down to:
Caveats: