Optional bigint support #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
requested changes
Jun 10, 2023
| @@ -0,0 +1,3 @@ | |||
| # Treat text as lf | |||
There was a problem hiding this comment.
Please remove this file from the PR.
There was a problem hiding this comment.
without it you're relying on windows contributors having git configured to commit LF instead of CRLF which doesn't seem ideal
| @@ -45,7 +45,7 @@ export function parse( | |||
| return parseLiteral(schema, keyName) | |||
| } | |||
|
|
|||
| const types = typesOfSchema(schema) | |||
| const types = typesOfSchema(schema, options) | |||
There was a problem hiding this comment.
Suggested change
| const types = typesOfSchema(schema, options) | |
| const types = typesOfSchema(schema) |
There was a problem hiding this comment.
options needs to be passed in so that the matchers can read the enableBigInt option
- This change isn't changing any of the existing behavior by default. - When enabled however, it'll generate integers with no 'maximum' property as 'bigint'. Why? While JSON supports big integers in its specification, JavaScript does not by default. Thus, trying to deserialise a large integer into a JavaScript number is doomed to fail. Since relatively recently however, JavaScript (and therefore TypeScript), natively supports a 'bigint' type for numbers (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt), and there exists fixed parsers that can parse numbers into bigint directly.
…outside the safe range for Number
tristanmenzel
force-pushed
the
optional-bigint-support
branch
from
0467afb
to
cb5799a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting PR401 to add bigint support.
Hopefully this PR addresses the outstanding comments on the original PR.