Fix issue with patternProperties and strictIndexSignatures option
#560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoriyasu Yano <430092+yorinasub17@users.noreply.github.com>
This was referenced Nov 18, 2023
…exSignatures Signed-off-by: Yoriyasu Yano <430092+yorinasub17@users.noreply.github.com>
yorinasub17
force-pushed
the
bug/patternproperties-and-strictindexsignatures
branch
from
afa8c56
to
6ca3749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559
See issue for details.
NOTE
This is my first time contributing here! I must admit that I do not fully grok the intricacies around the type issues as described in #235 , so I am not 100% certain this is the right fix. That said, this does address my compilation issues when generating from schemas in https://www.schemastore.org/json/.
Also, I am not familiar with
avaand snapshot testing, so I am not 100% sure I rebuilt the snapshot correctly, so pointers on how to regenerate it would be helpful if I did indeed do something wrong!