Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to remove comment about interface referencer #575

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stmated
Copy link

@Stmated Stmated commented Feb 1, 2024

When generating code using unreachableDefinitions it adds a comment to the interface stating This interface was referenced by....
I find this quite annoying. So I added an option to not include those comments.

Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but I'm not sure this change is worth the added complexity it introduces. We can revisit if there is significant interest from others (please feel welcome to open an issue).

@Stmated
Copy link
Author

Stmated commented Mar 13, 2024

Thanks for the contribution, but I'm not sure this change is worth the added complexity it introduces. We can revisit if there is significant interest from others (please feel welcome to open an issue).

You know what would bring even less complexity? Just removing the comment without any setting of enabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants