Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --all now respects --extension flag. #357

Merged
merged 6 commits into from
May 16, 2022
Merged

fix: --all now respects --extension flag. #357

merged 6 commits into from
May 16, 2022

Commits on May 16, 2022

  1. Change the --all flag to cooperate with the new --extension flag. 

    Instead of a few hard-coded extensions, `--all` will now respect any
custom extensions.

Backwards compatible if `--extension` flag is not used.

New test added, snapshots updated, everything is passing.

As an example: I'm using esmodule loaders to have Node.js load `.svelte` files
(see: [esm-loader-svelte](https://github.com/brev/esm-loader-svelte)). This
works great with the `--extension` flag, but `--all` was missing this new
extension. With this changeset, everything now works great.
    @brev @bcoe
    brev authored and bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    5eba77d View commit details
    Browse the repository at this point in the history

  2. chore: resolve conflict

    @bcoe
    bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a7b840d View commit details
    Browse the repository at this point in the history

  3. Update test/integration.js

    @bcoe
    bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    7fa1f77 View commit details
    Browse the repository at this point in the history

  4. Re-run snapshots with --clean=true.

    @brev @bcoe
    brev authored and bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    72a5781 View commit details
    Browse the repository at this point in the history

  5. chore: update snapshots

    @bcoe
    bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    dc87b08 View commit details
    Browse the repository at this point in the history

  6. chore: fix snapshots

    @bcoe
    bcoe committed May 16, 2022
    Configuration menu
    Copy the full SHA
    186825a View commit details
    Browse the repository at this point in the history