Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce LF in the repo. #61

Merged
merged 1 commit into from Oct 13, 2021
Merged

Enforce LF in the repo. #61

merged 1 commit into from Oct 13, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 5, 2021

On Windows autocrlf: true is the default which makes the linter sad.

This affects any Windows user who clone the repo, so this change fixes the issue properly.

On Windows `autocrlf: true` is the default which makes the linter sad.
@XhmikosR XhmikosR mentioned this pull request Oct 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #61 (4dd3e18) into master (8e72b7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          23       23           
  Lines         477      477           
=======================================
  Hits          442      442           
  Misses         35       35           
Flag Coverage Δ
ubuntu-latest-12 92.56% <ø> (ø)
ubuntu-latest-14 92.56% <ø> (ø)
windows-latest-12 92.47% <ø> (ø)
windows-latest-14 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8356ed...4dd3e18. Read the comment docs.

Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I don't interactive test on windows so thanks for pointing this out.

@bcomnes bcomnes merged commit 57502f5 into bcomnes:master Oct 13, 2021
@XhmikosR XhmikosR deleted the lf branch October 14, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants