Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to c8 for coverage #66

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Switch to c8 for coverage #66

merged 1 commit into from
Oct 13, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 5, 2021

c8 is much lighter https://packagephobia.com/result?p=nyc%2Cc8 and supports most of the things.

TODO:

  • verify if the lcov path is the same

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bcomnes bcomnes marked this pull request as ready for review October 5, 2021 16:35
@bcomnes bcomnes marked this pull request as draft October 6, 2021 19:59
@bcomnes
Copy link
Owner

bcomnes commented Oct 6, 2021

Didn't mean to mark this as a non-draft, was trying to get the CI to run. Sorry about that.

I'll try to get these merged soon.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 7, 2021

No worries, it seems this is fine as it is.

@XhmikosR XhmikosR marked this pull request as ready for review October 7, 2021 03:42
@bcomnes bcomnes merged commit 96363d7 into bcomnes:master Oct 13, 2021
@XhmikosR XhmikosR deleted the c8 branch October 14, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants