Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: switch to assert's strict mode #67

Merged
merged 1 commit into from
Oct 13, 2021
Merged

tests: switch to assert's strict mode #67

merged 1 commit into from
Oct 13, 2021
+33 −33

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 5, 2021

No description provided.

@XhmikosR
tests: switch to assert's strict mode

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
594ba79
@XhmikosR XhmikosR marked this pull request as ready for review October 5, 2021 05:47
bcomnes
bcomnes approved these changes Oct 5, 2021
View reviewed changes
Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I do have this open issue #24 that I might swallow some day. Any idea how power assert and strict assert interact, in case I ever get time to get that working again?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 5, 2021

Hmm, I never used power-assert TBH, I haven't even heard of it until now. :/

@bcomnes bcomnes merged commit 31f902b into bcomnes:master Oct 13, 2021
@XhmikosR XhmikosR deleted the tests-strict branch October 14, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @bcomnes