feat(types): add typescript definitions / add named export run #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bradvogel - when you get a chance can you take a look at this PR? |
ejhayes
force-pushed
the
master
branch
2 times, most recently
from
b2f65c8
to
a6c2235
Compare
|
Can you rebase on the latest origin/master? It looks like this PR diff is picking up some unrelated changes. |
… Add named export run that exports middleware/queues in arena.
|
Changes rebased against upstream master. Take a look now @bradvogel |
bradvogel
approved these changes
May 20, 2021
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ### [3.20.1](https://github.com/bee-queue/arena/compare/v3.20.0...v3.20.1) (2021-04-15) | |||
There was a problem hiding this comment.
No need to update this file. It's done automatically when this PR is merged. See https://github.com/bee-queue/arena/commits/master/CHANGELOG.md
bradvogel
requested changes
May 20, 2021
| @@ -1,4 +1,6 @@ | |||
| *.hbs | |||
| *.min.js | |||
| *.min.css | |||
| *.d.ts | |||
| tsconfig.json | |||
There was a problem hiding this comment.
CI is failing. I think you need to ignore the /dist folder here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
package.jsonwhich includestypesreference and scriptgenerate:types)runwhich exports bothappandqueue. Simplifies process of adding/removing queues from arena. This does not change default behavior!README.mdPotential Risks
Test Plan
example/directory work. I have confirmed these work for meChecklist