Config BKS using ini file #1929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack did not recognize optional chaining token (?.) webpack/webpack#10227 (comment)
- Handled configs that use arrays - Added keybindings converter for electron accelerator and v-hotkey - Added more keybindings to cover all components that use v-hotkey - Generalized keybindings and refactor some names
|
@azmy60 ok, I'm ready to merge this!! Can you fix the merge conflicts and address the PR review todos? |
|
Yes. I'll do that today. |
|
@rathboma should we merge this to master? or is there a custom branch like |
|
Also, I'm not sure which PR review todos you're referring to. |
rathboma
requested changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1911