feat: shortcut added for reopening last closed tab #1963
Conversation
|
Hi @rathboma here is the video. Let me know if it's okay or I'm missing something here Screencast.from.2024-04-05.15-16-25.mp4 |
|
Hey, it will work, but when you close and re-open Beekeeper Studio those tabs will be missing, because they were deleted from the database. That's why the tabs need to go through the sequence I described. |
|
@azmy60 this doesn't require much to fix for merging, see the comments above. You should be able to commit directly to this branch. |
| async reopenLastClosedTab(context) { | ||
| for (let i = context.state.lastClosedTabs.length - 1; i >= 0; i--) { | ||
| const tab = context.state.lastClosedTabs[i] | ||
| // Does this tab belong to the current connection? |
There was a problem hiding this comment.
Do you also have to check workspace id?
There was a problem hiding this comment.
The OpenTab here has still been removed from the database and doesn't have an ID, so it still needs saving.
Also -- what happens with the position of the tab? Does it go back to the right place?
There was a problem hiding this comment.
I was under the impression that we want this to behave like vscode, so no need to save lastClosedTabs to database. But I just realized that chrome persists the closed tabs even though I exit the program. I'll take a look on that.
There was a problem hiding this comment.
Should we even not remove tabs from database and just mark it as "closed"? like soft delete.
| @@ -78,6 +86,18 @@ export const TabModule: Module<State, RootState> = { | |||
| context.commit('set', []) | |||
| context.commit('setActive', null) | |||
| }, | |||
| async reopenLastClosedTab(context) { | |||
| for (let i = context.state.lastClosedTabs.length - 1; i >= 0; i--) { | |||
There was a problem hiding this comment.
Why are we looping here? We only want the very last item in the lastClosedTabs array.
There was a problem hiding this comment.
This is to avoid opening a tab that's from a different connection.
Using array.pop would get the last item, but that item could be from a different connectionId.
An example to this case is:
- close tabs in connection A
- disconnect from A and connect to B
- press ctrl+shift+T
- tabs that were in connection A are now in B
Another solution to this is I was thinking if we should just wipe out the stack so it's empty whenever we connect to a new connection, but maybe it's better to do the first one since we can?
EDIT: This implementation will probably change to using array.pop if I save the closed tabs to database.
It's hard to restore closed tabs in the right position, when all positions of tabs were always `99`.
addressing: #1768
added Ctrl+Shift+T shortcut to re-open recently closed tab