-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Filter saved queries and connections #2161
base: master
Are you sure you want to change the base?
Conversation
Looks great! Will merge after the next release - can you make sure this works in ultimate with workspaces? |
@rathboma will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this workspace enabled?
@@ -9,9 +9,35 @@ export const LocalQueryModule: DataStore<FavoriteQuery, DataState<FavoriteQuery> | |||
loading: false, | |||
error: null, | |||
pollError: null, | |||
filter: undefined // maybe this can be more advanced? date filter? | |||
}, | |||
mutations: mutationsFor<FavoriteQuery>({ | |||
// more mutations go here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So looks like this isn't implemented for queries and connections that come from the cloud?
resolve #2033
This allows the user to filter saved connections and saved queries: