Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor resolveLanguage #2162

Merged
merged 2 commits into from
May 15, 2024
Merged

refactor resolveLanguage #2162

merged 2 commits into from
May 15, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Apr 26, 2024

close #2110

rathboma
rathboma requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@rathboma rathboma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to kill resolveSqlLanguage all together

apps/studio/src/lib/editor/languageData.ts Outdated Show resolved Hide resolved
@azmy60 azmy60 requested a review from rathboma May 12, 2024 11:17
@rathboma rathboma merged commit 51f076a into master May 15, 2024
13 checks passed
@rathboma rathboma deleted the chore/resolve-language branch May 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathboma rathboma rathboma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CHORE: Generalize LanguageData#resolveLanguage so we don't have to add a line when we add a new driver
2 participants
@azmy60 @rathboma